Code changes to enable player thumbnail seekbar preview in NewPipe #647

litetex · 2021-06-05T20:37:54Z

I carefully read the contribution guidelines and agree to them.
I have tested the API against NewPipe.
I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

This pr is required for fixing TeamNewPipe/NewPipe#3207
This is the nested/required PR for TeamNewPipe/NewPipe#6434

Also fixes: #595

Changes

Exposed the thumbnail preview frames

TobiGr

Looks good. Just one small thing.

Note for whoever this is merging: please squash

extractor/src/main/java/org/schabi/newpipe/extractor/stream/Frameset.java

litetex · 2021-06-08T18:16:56Z

Wait a moment, when a very short video is played (e.g. https://www.youtube.com/watch?v=jhFDyDgMVUI) then the extractor fails:

-------------------------------------
org.schabi.newpipe.extractor.exceptions.ExtractionException: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String[] java.lang.String.split(java.lang.String)' on a null object reference
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.getFrames(YoutubeStreamExtractor.java:1099)
	at org.schabi.newpipe.extractor.stream.StreamInfo.extractOptionalData(StreamInfo.java:339)
	at org.schabi.newpipe.extractor.stream.StreamInfo.getInfo(StreamInfo.java:73)
	at org.schabi.newpipe.extractor.stream.StreamInfo.getInfo(StreamInfo.java:64)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$getStreamInfo$3(ExtractorHelper.java:115)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$YTHJjScxCJNO1LTCqs3IKy35iyY.call(Unknown Source:4)
	at io.reactivex.rxjava3.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:43)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4813)
	at io.reactivex.rxjava3.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4813)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeFromSingle.subscribeActual(MaybeFromSingle.java:41)
	at io.reactivex.rxjava3.core.Maybe.subscribe(Maybe.java:5330)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.drain(MaybeConcatArray.java:153)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.request(MaybeConcatArray.java:78)
	at io.reactivex.rxjava3.internal.operators.flowable.FlowableElementAtMaybe$ElementAtSubscriber.onSubscribe(FlowableElementAtMaybe.java:66)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeConcatArray.subscribeActual(MaybeConcatArray.java:42)
	at io.reactivex.rxjava3.core.Flowable.subscribe(Flowable.java:15753)
	at io.reactivex.rxjava3.internal.operators.flowable.FlowableElementAtMaybe.subscribeActual(FlowableElementAtMaybe.java:36)
	at io.reactivex.rxjava3.core.Maybe.subscribe(Maybe.java:5330)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeToSingle.subscribeActual(MaybeToSingle.java:46)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4813)
	at io.reactivex.rxjava3.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.rxjava3.core.Scheduler$DisposeTask.run(Scheduler.java:614)
	at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:65)
	at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:56)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:923)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String[] java.lang.String.split(java.lang.String)' on a null object reference
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.getFrames(YoutubeStreamExtractor.java:1061)
	... 29 more
-------------------------------------

TobiGr · 2021-06-08T20:04:44Z

Something simple like TobiGr/NewPipeExtractor@e831c0e should solve that

litetex · 2021-06-09T18:19:53Z

@TobiGr
Was already fixed with fb7228a

Stypox · 2021-06-13T19:11:08Z

@litetex were you able to find out the problem?

litetex · 2021-06-13T19:47:51Z

@Stypox

@litetex were you able to find out the problem?

Yes, as stated above, it was already fixed with fb7228a 😄

TobiGr · 2021-06-14T08:29:44Z

Please replace new ArrayList<>() with Collection.emptyList().

...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java

litetex · 2021-06-15T19:58:48Z

@TobiGr

Please replace new ArrayList<>() with Collection.emptyList().

Done 😄

extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfo.java

litetex · 2021-06-27T12:44:48Z

Rebased the branch again and applied @Stypox changes.

Any change of getting this merged soon?
Getting tired of rebasing the branch every week 😢

Stypox · 2021-07-05T08:51:33Z

Any change of getting this merged soon?

After 0.21.6 is released I'd merge this right away @TobiGr

Reformatted code

To fix ``java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String[] java.lang.String.split(java.lang.String)' on a null object reference``

java.lang.RuntimeException: Parcelable encountered IOException writing serializable object (name = org.schabi.newpipe.extractor.stream.StreamInfo) ... Caused by: java.io.NotSerializableException: org.schabi.newpipe.extractor.stream.Frameset ...

Outdated

litetex changed the title ~~Code changes to enable player seekbar preview in NewPipe~~ Code changes to enable player thumbnail seekbar preview in NewPipe Jun 5, 2021

litetex mentioned this pull request Jun 5, 2021

Player seekbar thumbnail preview TeamNewPipe/NewPipe#6434

Merged

5 tasks

litetex marked this pull request as ready for review June 5, 2021 22:53

Stypox approved these changes Jun 6, 2021

View reviewed changes

TobiGr approved these changes Jun 8, 2021

View reviewed changes

extractor/src/main/java/org/schabi/newpipe/extractor/stream/Frameset.java Outdated Show resolved Hide resolved

litetex force-pushed the playerSeekbarPreview branch from 0bcb4d7 to d8672a4 Compare June 8, 2021 19:11

litetex commented Jun 14, 2021

View reviewed changes

...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java Outdated Show resolved Hide resolved

litetex commented Jun 14, 2021

View reviewed changes

...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java Outdated Show resolved Hide resolved

litetex marked this pull request as draft June 14, 2021 19:43

litetex force-pushed the playerSeekbarPreview branch from d8672a4 to eb0a74b Compare June 15, 2021 17:40

litetex marked this pull request as ready for review June 15, 2021 19:58

litetex mentioned this pull request Jun 16, 2021

Frames aren't available in StreamInfo #595

Closed

Stypox previously requested changes Jun 18, 2021

View reviewed changes

extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfo.java Outdated Show resolved Hide resolved

litetex force-pushed the playerSeekbarPreview branch 2 times, most recently from af1dede to 90b87b0 Compare June 27, 2021 12:43

litetex force-pushed the playerSeekbarPreview branch from 90b87b0 to 794111d Compare July 6, 2021 19:05

TobiGr approved these changes Jul 13, 2021

View reviewed changes

TobiGr requested a review from Stypox July 13, 2021 21:00

litetex added 3 commits July 17, 2021 16:41

Added seekbar data

93b0c5b

Reverted useless change

b086655

Renamed frames to previewFrames (so it's better understandable)

09b670d

litetex added 5 commits July 17, 2021 16:41

Update Frameset.java

4e41e17

Reformatted code

Update YoutubeStreamExtractor.java

17ccaf4

To fix ``java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String[] java.lang.String.split(java.lang.String)' on a null object reference``

Using Collections.emptyList()

ecf4232

Review changes

0c12b39

litetex force-pushed the playerSeekbarPreview branch from 794111d to 0c12b39 Compare July 17, 2021 14:41

TobiGr merged commit ada67d1 into TeamNewPipe:dev Jul 17, 2021

litetex deleted the playerSeekbarPreview branch July 19, 2021 18:39

litetex restored the playerSeekbarPreview branch July 19, 2021 19:09

litetex deleted the playerSeekbarPreview branch July 19, 2021 19:28

Stypox mentioned this pull request Aug 3, 2021

Hotfix release 0.21.8 TeamNewPipe/NewPipe#6834

Merged

Uh oh!

Code changes to enable player thumbnail seekbar preview in NewPipe #647

Code changes to enable player thumbnail seekbar preview in NewPipe #647

Uh oh!

Conversation

litetex commented Jun 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

TobiGr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

litetex commented Jun 8, 2021

Uh oh!

TobiGr commented Jun 8, 2021

Uh oh!

litetex commented Jun 9, 2021

Uh oh!

Stypox commented Jun 13, 2021

Uh oh!

litetex commented Jun 13, 2021

Uh oh!

TobiGr commented Jun 14, 2021

Uh oh!

Uh oh!

Uh oh!

litetex commented Jun 15, 2021

Uh oh!

Uh oh!

litetex commented Jun 27, 2021

Uh oh!

Stypox commented Jul 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

litetex commented Jun 5, 2021 •

edited

Loading

TobiGr left a comment •

edited

Loading