Specify UTF-8 file encoding in RecordingDownloader and MockDownloader #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
force-pushed
the
utf-8-encoding-for-mocks-windows
branch
from
fcea50a to
ac31f3a
Compare
On Windows, mocks are recorded and read with the Cp1252 encoding so it breaks the mocks on non ASCII characters for Linux OS (and so the CI). The project is in Java 8, so we can't use FileReader(File, Charset) and FileReader(File, Charset) because these methods require Java 11. Instead of changing the Java version of the extractor, use OutputStreamWriter and FileOutputStream instead of FileWriter and InputStreamReader and FileInputStream instead of FileReader.
XiangRongLin
approved these changes
Jun 3, 2021
This was referenced Jun 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, mocks are recorded and read with the Cp1252 encoding so it breaks the mocks for non ASCII characters on Linux OS (and so the CI).
The project is in Java 8, so we can't use
FileReader(File, Charset)andFileReader(File, Charset)because these constructors require Java 11. Instead of changing the Java version of the extractor, useOutputStreamWriterandFileOutputStreamobjets instead ofFileWriterobjects and useInputStreamReaderandFileInputStreamobjects instead ofFileReaderobjects.Fixes #643.