Skip to content

[YouTube] Fixed getting video info for age restricted and not available streams #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TobiGr merged 2 commits into from
May 23, 2021
Merged

[YouTube] Fixed getting video info for age restricted and not available streams #629

TobiGr merged 2 commits into from
May 23, 2021

Conversation

@TechComet
Copy link
Contributor

@TechComet TechComet commented May 21, 2021

No description provided.

@TobiGr
Copy link
Contributor

TobiGr commented May 21, 2021

please add a description telling us why this change is needed / which issue is resolved by it

@TobiGr TobiGr added the youtube service, https://www.youtube.com/ label May 21, 2021
TechComet
TechComet commented May 21, 2021
View reviewed changes
Copy link
Contributor Author

@TechComet TechComet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add new pattern required html5=1

@TechComet
Copy link
Contributor Author

TechComet commented May 21, 2021

This not work before add html5=1
https://www.youtube.com/get_video_info?video_id=YudpwPkemzU&eurl=https://youtube.googleapis.com/v/YudpwPkemzU

This work after add html5=1
https://www.youtube.com/get_video_info?video_id=YudpwPkemzU&html5=1&eurl=https://youtube.googleapis.com/v/YudpwPkemzU

@AudricV AudricV changed the title Update YoutubeStreamExtractor.java [YouTube] Fix the fetch of the video info page May 22, 2021
@AudricV AudricV added the bug Issue is related to a bug label May 22, 2021
This was referenced May 22, 2021
Closed
Closed
AudricV
AudricV approved these changes May 22, 2021
View reviewed changes
Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this, @TechComet is right: without the html5 param, the request returns 404 Not Found. @TobiGr What do you think?

@XiangRongLin XiangRongLin linked an issue May 22, 2021 that may be closed by this pull request
Fix failing tests related to unavailable content #632
Closed
@XiangRongLin XiangRongLin mentioned this pull request May 23, 2021
Closed
4 tasks
@TobiGr
Copy link
Contributor

TobiGr commented May 23, 2021

@XiangRongLin I added you mock update commit. Was about to do generate them myself, but saw that you already did that :)

TobiGr
TobiGr approved these changes May 23, 2021
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TechComet Thank you

@TobiGr TobiGr merged commit fadf677 into TeamNewPipe:dev May 23, 2021
@XiangRongLin
Copy link
Collaborator

XiangRongLin commented May 23, 2021

@TobiGr How the heck are you able to merge the PR inside his repo?!?

@XiangRongLin XiangRongLin mentioned this pull request May 23, 2021
Closed
@opusforlife2
Copy link
Collaborator

opusforlife2 commented May 23, 2021

He's a wizzzard. O.o

@triallax triallax mentioned this pull request May 23, 2021
Closed
@opusforlife2 opusforlife2 changed the title [YouTube] Fix the fetch of the video info page [YouTube] Fixed getting video info for age restricted and not available streams May 28, 2021
@opusforlife2
Copy link
Collaborator

opusforlife2 commented May 29, 2021

@TechComet Always make sure to include a description of what feature your PR is adding or what bug it is fixing. Non-developers need to understand what the PR is doing as well.

@ShareASmile ShareASmile mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TobiGr TobiGr TobiGr approved these changes

@AudricV AudricV AudricV approved these changes

Assignees

No one assigned

Labels

bug Issue is related to a bug youtube service, https://www.youtube.com/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix failing tests related to unavailable content

5 participants

@TechComet @TobiGr @XiangRongLin @opusforlife2 @AudricV