Load more featured pages and fix featured cover arts not loading #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
reviewed
Mar 31, 2021
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
Looks good. Just one small thing.
...ava/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampFeaturedExtractor.java
Outdated
Show resolved
Hide resolved
fynngodau
force-pushed
the
bandcamp-more-recent-pages
branch
from
b161ecc to
705f6c6
Compare
TobiGr
approved these changes
Mar 31, 2021
This was referenced Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #584
→ NewPipe now allows scrolling the Bandcamp Featured screen by more than 10 items by loading additional pages.
Fixes #587
→ As described there, use
item_art_idifart_idis not available. This fixes broken cover arts on the featured screen.I verified against the Bandcamp Inc. app that the featured screen displays the same items (besides tracks, #588).