Skip to content

Conversation

@B0pol
Copy link
Member

@B0pol B0pol commented Feb 20, 2021

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

#352 with minor changes and rebased.

@B0pol B0pol force-pushed the invidious_2 branch 2 times, most recently from 9e43a06 to 1bc8703 Compare February 20, 2021 18:10
Copy link
Member

@FireMasterK FireMasterK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

*/
void fetchInstanceMetaData() throws InvalidInstanceException;

} No newline at end of file
Copy link
Member

@FireMasterK FireMasterK Feb 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the missing newline.

import org.schabi.newpipe.extractor.NewPipe;
import org.schabi.newpipe.extractor.StreamingService;
import org.schabi.newpipe.extractor.exceptions.ContentNotAvailableException;
import org.schabi.newpipe.extractor.exceptions.ExtractionException;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you can see it's a draft PR meaning it's not finished

@AudricV AudricV added invidious Service, https://invidious.io new service Issues (feature request) or PR related to a new service labels Mar 5, 2021
@B0pol B0pol closed this Jun 17, 2021
litetex added a commit to litetex/NewPipeExtractor that referenced this pull request Apr 15, 2022
* allows usage of YouTubeLike services, e.g. invidious
* simplified some classes/code
* Added support for invidious
  * Some credits go to @B0pol's PR TeamNewPipe#555 for that ;)
litetex added a commit to litetex/NewPipeExtractor that referenced this pull request Apr 15, 2022
* allows usage of YouTubeLike services, e.g. invidious
* simplified some classes/code
* Added support for invidious
  * Some credits go to @B0pol's PR TeamNewPipe#555 for that ;)
litetex added a commit to litetex/NewPipeExtractor that referenced this pull request Apr 21, 2022
* allows usage of YouTubeLike services, e.g. invidious
* simplified some classes/code
* Added support for invidious
  * Some credits go to @B0pol's PR TeamNewPipe#555 for that ;)
litetex added a commit to litetex/NewPipeExtractor that referenced this pull request May 7, 2022
* allows usage of YouTubeLike services, e.g. invidious
* simplified some classes/code
* Added support for invidious
  * Some credits go to @B0pol's PR TeamNewPipe#555 for that ;)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invidious Service, https://invidious.io new service Issues (feature request) or PR related to a new service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants