Merged
Conversation
Stypox
requested changes
Jan 15, 2021
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
I agree failing tests should be ignored, until proper mocked tests exist
...rc/test/java/org/schabi/newpipe/extractor/services/peertube/PeertubeStreamExtractorTest.java
Outdated
Show resolved
Hide resolved
extractor/src/test/java/org/schabi/newpipe/extractor/services/DefaultStreamExtractorTest.java
Outdated
Show resolved
Hide resolved
XiangRongLin
force-pushed
the
ignore_failing
branch
from
0ff3c3a to
6888e77
Compare
Stypox
approved these changes
Jan 15, 2021
Collaborator
Author
|
@Stypox So much for ignoring failing tests. There are already new ones 😄 |
This was referenced Jan 15, 2021
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore all currently failing tests.
This way one finally can see again if the own changes broke something (additionally).
I'll unignore the ones where there are only minor string changes, when i adjust them to inject the mocks. The ones that are actually broken, have to be fixed by someone else in the future.