Conversation
|
Why is the build-and-test action failing? |
|
@opusforlife2 It's been failing for a very long time because part of the extractor is simply broken or the tests are broken. See #481 for more information and the linked PR where i try to address it. But haven't really gotten much feedback so i guess it is going to stay like stay for a while |
|
@TobiGr this is a trivial change, tested by a few people already. Please merge. |
TobiGr
left a comment
There was a problem hiding this comment.
I don't remember the reason, by that specific codec was commented out on purpose. However, I did not find any bugs with the current player implementation, so I'll merge this PR.
@TobiGr I think it was before magic man kapodamy implemented merging of video-only + audio-only streams for downloading. You could only download video-only streams, so there needed to be at least one format that would have sound in it, and that was the 360p mp4. |
I have tested the API against NewPipe.No, see webm 360p not showing up NewPipe#5363apk https://github.com/XiangRongLin/NewPipe/actions/runs/472076189
@Redirion