Skip to content

[media.ccc.de] Recent kiosk: order streams by upload date#504

Merged
Stypox merged 1 commit intodevfrom
media.ccc.de_recent_order
Jan 14, 2021
Merged

[media.ccc.de] Recent kiosk: order streams by upload date#504
Stypox merged 1 commit intodevfrom
media.ccc.de_recent_order

Conversation

@TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Dec 30, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Fixes TeamNewPipe/NewPipe#5313

@TobiGr TobiGr added bug Issue is related to a bug media.ccc.de service, https://media.ccc.de labels Dec 30, 2020
Comment on lines 44 to 51
Comparator<StreamInfoItem> comparator = Comparator.comparing(
streamInfoItem -> streamInfoItem.getUploadDate().offsetDateTime());
comparator = comparator.reversed();
StreamInfoItemsCollector collector = new StreamInfoItemsCollector(getServiceId(), comparator);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, that does not work:

Suggested change
Comparator<StreamInfoItem> comparator = Comparator.comparing(
streamInfoItem -> streamInfoItem.getUploadDate().offsetDateTime());
comparator = comparator.reversed();
StreamInfoItemsCollector collector = new StreamInfoItemsCollector(getServiceId(), comparator);
StreamInfoItemsCollector collector = new StreamInfoItemsCollector(getServiceId(), Comparator.comparing(
streamInfoItem -> streamInfoItem.getUploadDate().offsetDateTime()).reversed());

@TobiGr TobiGr force-pushed the media.ccc.de_recent_order branch from 01ef3ee to 5dc9a76 Compare December 30, 2020 17:38
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :-D

@Stypox Stypox merged commit 951159f into dev Jan 14, 2021
@TobiGr TobiGr mentioned this pull request Jan 18, 2021
14 tasks
@litetex litetex deleted the media.ccc.de_recent_order branch March 19, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug media.ccc.de service, https://media.ccc.de

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Media.CCC.de Recent list appears out of order

2 participants