[PeerTube] fix account and channel extractors #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
approved these changes
Oct 29, 2020
TobiGr
added
bug
Collaborator
This PR is also failing travis. Oh, the irony. :P |
Member
Author
|
But PeerTube channels / account extractors are not failing. |
Stypox
approved these changes
Oct 30, 2020
This was referenced Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix extractors, remove two @disabled tests and test them
You can see they were failing with travis (latest commit on dev):
https://travis-ci.org/github/TeamNewPipe/NewPipeExtractor/builds/739758202#L312
because we were querying HTML and trying to parse JSON.