Polish #442
Merged
Polish #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
B0pol
commented
Oct 26, 2020
B0pol
commented
- I carefully read the contribution guidelines and agree to them.
- I have tested the API against NewPipe.
- I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.
TheAssassin
reviewed
Oct 26, 2020
Member
TheAssassin
left a comment
TheAssassin
left a comment
There was a problem hiding this comment.
Looks good. The tests should be restored with different channels, if possible. Consider opening an issue about this.
...va/org/schabi/newpipe/extractor/services/youtube/search/YoutubeMusicSearchExtractorTest.java
Show resolved
Hide resolved
Member
Author
|
I opened #443 |
TheAssassin
approved these changes
Oct 26, 2020
Member
TheAssassin
left a comment
TheAssassin
left a comment
There was a problem hiding this comment.
I think it's okay, but I'd wait for @TobiGr to approve it as well.
Stypox
reviewed
Oct 26, 2020
| } catch (IOException e) { | ||
| throw new ParsingException( | ||
| "Could load decryption code form restricted video for the Youtube service.", e); | ||
| "Could load deobfuscation code form restricted video for the Youtube service.", e); |
Member
There was a problem hiding this comment.
Mmmh, this should probably be "Could not load deobfuscation code for YouTube restricted video"
Member
Author
There was a problem hiding this comment.
Sounds good. Feel free to open a PR
This was referenced Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.