Add support for different types of stream delivery by a service #358

mauriciocolli · 2020-06-21T17:31:52Z

I was working in an extractor for Twitch, and this was needed as it only offer HLS streams.

This also fixes some issues that some YouTube videos were having, as they only had DASH streams. We should be able to fix SoundCloud as well now, I'll leave it for later.

Add a field describing how a stream is delivered by a service
YouTube
- Improve DASH manifest parsing
- Ignore streams using the "OTF" delivery format

Closes #273

Some videos, especially those that have low views, don't have the usual direct links to all streams, this fix it by properly parsing the DASH manifest from those special cases.

Rely on the DASH manifest streams instead.

opusforlife2

Not a review, just curiosity.

opusforlife2 · 2020-06-22T01:21:58Z

extractor/src/main/java/org/schabi/newpipe/extractor/stream/VideoStream.java

+        this(null, deliveryFormat, format, resolution, false);
    }

-    public VideoStream(String url, String torrentUrl, MediaFormat format, String resolution) {


You've replaced 4 VideoStreams by 3. Why doesn't this one have a replacement?

Also, what is the OTF delivery format? Can't find any information online whatsoever.

You've replaced 4 VideoStreams by 3. Why doesn't this one have a replacement?

It was used only in one place I think, so I just removed it. It doesn't make a difference anyway.

Also, what is the OTF delivery format? Can't find any information online whatsoever.

Yeah, I don't know exactly, didn't dig too much on it, but it seems to be some sort of in-house playback solution by YouTube, it works pretty much like DASH.

yausername · 2020-06-24T11:44:11Z

extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfo.java

+                final List<AudioStream> audioStreams =
+                        new ArrayList<>(streamInfo.getAudioStreams());
+
+                final DashMpdParser.Result result = DashMpdParser.getStreams(streamInfo);


How about we call it YoutubeDashMpdParser and move this code to YoutubeStreamExtractor? Let the service extractors do dash manifest parsing if required.
Or should we have a generic parser that can handle all services like youtube-dl does?

yausername · 2020-06-24T11:58:36Z

A few questions.

Would it make sense to have getHlsUrl and getDashMpdUrl return a list instead of a string?
How about parsing the HLS manifest similar to how we parse DASH to get different representations of the stream. This can help in, for example selecting live stream resolution for youtube.

wb9688 · 2020-06-24T17:15:50Z

First of all: I still haven't looked at your implementation.

My idea was to do the following:

Add a type attribute to Stream, which could be one of: progressive HTTP, DASH, HLS or (Web)Torrent.
- This also means that there won't be a torrentUrl attribute anymore, but those will be 2 separate instances of Stream.
Add an id attribute to Stream, which ideally has the original ID the service assigns. This ID should be unique for every stream, but when a stream is provided as e.g. both progressive HTTP and WebTorrent, those 2 instances of Stream will be the same.
Add a content attribute to Stream, which could be used instead of url for DASH and HLS and contains the actual manifest itself as String.
Add every stream (i.e. Representation in case of DASH) as a separate Stream with just the relevant part of the DASH manifest in the content attribute.
Change getDashMpdUrl() and getHlsUrl() to return a Stream with either an url to the full manifest (like YouTube) or with content where we merge the different manifests (like SoundCloud when there's both a MP3 HLS URL and an Opus HLS URL).
- This means we could use those for an "Auto" resolution option.
- Also rename those functions to something not containing the word URL.
Automatically parse the resolution, format, etc from the YouTube streams instead of using our hardcoded ITAG_LIST, which is pretty incomplete.
- Also add attributes for HDR and 360° videos.
Maybe merge AudioStream, VideoStream, and SubtitlesStream into just Stream, with nullable attributes.

This all obviously doesn't need to be done in a single PR.

yausername · 2020-06-30T03:14:22Z

extractor/src/main/java/org/schabi/newpipe/extractor/stream/DeliveryFormat.java

+/**
+ * A class that is used to represent the way that a streaming service deliver their streams.
+ */
+public abstract class DeliveryFormat implements Serializable {


Can you make this class an interface and add a getUrl method? This will save us some casts.

clarfonthey · 2020-08-03T15:33:01Z

@mauriciocolli Any plans to continue work on this?

wb9688 · 2020-08-03T15:35:19Z

@clarfon: Also see my #367. I'll do the NewPipe part of it soon (hopefully for v0.20.1).

Stypox · 2021-08-04T15:45:30Z

Closing in favour of #663

ShareASmile · 2022-11-15T01:56:20Z

for the records:-
Support delivery methods other than progressive HTTP implemented by #810

opusforlife2 · 2022-11-16T07:43:29Z

Why would you necro such an old PR, @ShareASmile!? The PR linked by Stypox is further linked to the merged one.

mauriciocolli added 3 commits June 21, 2020 13:57

Add a field describing how a stream is delivered by a service

e83368e

[YouTube] Improve DASH manifest parsing

7262690

Some videos, especially those that have low views, don't have the usual direct links to all streams, this fix it by properly parsing the DASH manifest from those special cases.

[YouTube] Ignore streams using the "OTF" format

f291309

Rely on the DASH manifest streams instead.

mauriciocolli mentioned this pull request Jun 21, 2020

Add player support for different types of stream delivery TeamNewPipe/NewPipe#3803

Closed

4 tasks

mauriciocolli added the enhancement New feature or request label Jun 21, 2020

opusforlife2 reviewed Jun 22, 2020

View reviewed changes

[SoundCloud] Add support for the available HLS streams

c234a6d

yausername reviewed Jun 24, 2020

View reviewed changes

yausername reviewed Jun 30, 2020

View reviewed changes

yausername mentioned this pull request Jul 1, 2020

bbc sounds support #364

Closed

3 tasks

wb9688 mentioned this pull request Aug 5, 2020

Properly support other delivery methods #367

Closed

8 tasks

opusforlife2 mentioned this pull request Jun 7, 2021

[HELP NEEDED] Major planned/missing features TeamNewPipe/NewPipe#6448

Open

34 tasks

Stypox closed this Aug 4, 2021

Uh oh!

Add support for different types of stream delivery by a service #358

Add support for different types of stream delivery by a service #358

Uh oh!

Conversation

mauriciocolli commented Jun 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

opusforlife2 left a comment

Choose a reason for hiding this comment

Uh oh!

opusforlife2 Jun 22, 2020

Choose a reason for hiding this comment

Uh oh!

opusforlife2 Jun 22, 2020

Choose a reason for hiding this comment

Uh oh!

mauriciocolli Jun 24, 2020

Choose a reason for hiding this comment

Uh oh!

yausername Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yausername commented Jun 24, 2020

Uh oh!

wb9688 commented Jun 24, 2020

Uh oh!

yausername Jun 30, 2020

Choose a reason for hiding this comment

Uh oh!

clarfonthey commented Aug 3, 2020

Uh oh!

wb9688 commented Aug 3, 2020

Uh oh!

Stypox commented Aug 4, 2021

Uh oh!

ShareASmile commented Nov 15, 2022

Uh oh!

opusforlife2 commented Nov 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mauriciocolli commented Jun 21, 2020 •

edited

Loading

yausername Jun 24, 2020 •

edited

Loading