Fix SoundCloud client_id extraction and update SoundCloud client_id#217
Merged
Fix SoundCloud client_id extraction and update SoundCloud client_id#217
Conversation
TobiGr
commented
Nov 29, 2019
.../src/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudParsingHelper.java
Show resolved
Hide resolved
Stypox
previously approved these changes
Dec 9, 2019
.../src/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudParsingHelper.java
Show resolved
Hide resolved
Contributor
Author
|
@Stypox What can we do about the 401 response when accessing a stream? With that PR we are just able to view pages, don't ask me why. |
Don't throw exception when hard coded client_id is wrong. Addresses TeamNewPipe/NewPipe#2823
34228b3 to
54d1a1a
Compare
Contributor
Author
|
I am not able to fix the stream issue... That's why I will not prepare a hotfix release and this will be merged to the dev branch |
This was referenced Dec 12, 2019
Contributor
|
I saw this fail in the Travis CI log: Here are the stream URLs for this track:
https://github.com/ytdl-org/youtube-dl/blob/master/youtube_dl/extractor/soundcloud.py helped me a bit. I used I hope it can help you. :) |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't throw exception when hard coded client_id is wrong.
Addresses TeamNewPipe/NewPipe#2823
There is still one problem left: the audioStreamTest fails with a 401 response. Can someone please look into this?
CC @mauriciocolli @Stypox @theScrabi