use webm as format for opus audio streams#199
Merged
TobiGr merged 6 commits intoTeamNewPipe:devfrom Nov 24, 2019
kapodamy:yt-webm-opus
Merged
use webm as format for opus audio streams#199TobiGr merged 6 commits intoTeamNewPipe:devfrom kapodamy:yt-webm-opus
TobiGr merged 6 commits intoTeamNewPipe:devfrom
kapodamy:yt-webm-opus
Conversation
declare WEBMA_OPUS
kapodamy
changed the title
theScrabi
approved these changes
Sep 24, 2019
Member
|
I kind of messed this up when I didn't distinguish between stream and container format. This could one day be cleared up. |
Contributor
Author
|
ok |
2 tasks
Contributor
|
Sorry for the delay. We should have merged this right after @theScrabi's approval. |
Contributor
|
@kapodamy Can you rebase it please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opus suffix is only used if the container format is
oggbut youtube delivers the audio inwebmformat.This PR updates the itags in youtube extractor for
webm