Fix YouTube subscriber count #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify test to fail on too small subscriber count
TobiGr
force-pushed
the
subscriber-count
branch
from
294eda5 to
06016d1
Compare
Stypox
requested changes
Sep 17, 2019
Add Billion to mixedNumberWordToLong
TobiGr
force-pushed
the
subscriber-count
branch
from
decf379 to
6d504e0
Compare
mauriciocolli
added a commit
to mauriciocolli/NewPipeExtractor
that referenced
this pull request
Oct 2, 2019
Contributor
|
Just a question: Shouldn't we have a way to indicate when we don't have a precise number available? It's a shame if someone is using this library as their source of information for some project that depends on it (e.g. track subscribers over time). Keep in mind that this change would just make the wording/results more accurate, the user would still have to live with that. Maybe including a warning in the documentation is enough? |
Contributor
Author
Yes, you are right. A warning in the docs is the minimum, maybe printing a warning to the console would be a good compromise, but even a new method (something like |
3 tasks
mauriciocolli
added a commit
to mauriciocolli/NewPipeExtractor
that referenced
this pull request
Oct 6, 2019
mauriciocolli
added a commit
to mauriciocolli/NewPipeExtractor
that referenced
this pull request
Oct 11, 2019
mauriciocolli
added a commit
to mauriciocolli/NewPipeExtractor
that referenced
this pull request
Oct 28, 2019
mauriciocolli
added a commit
to mauriciocolli/NewPipeExtractor
that referenced
this pull request
Oct 28, 2019
mauriciocolli
added a commit
to mauriciocolli/NewPipeExtractor
that referenced
this pull request
Nov 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify test to fail on too small subscriber count
Fixes TeamNewPipe/NewPipe#2632
CC @theScrabi @Stypox