Add support for music.youtube.com to link handler#194
Merged
TobiGr merged 2 commits intoTeamNewPipe:devfrom Sep 12, 2019
Merged
Add support for music.youtube.com to link handler#194TobiGr merged 2 commits intoTeamNewPipe:devfrom
TobiGr merged 2 commits intoTeamNewPipe:devfrom
Conversation
Stypox
requested changes
Sep 12, 2019
Member
There was a problem hiding this comment.
You should probably add a test in YoutubeStreamLinkHandlerFactoryTest: https://github.com/TeamNewPipe/NewPipeExtractor/blob/dev/extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeStreamLinkHandlerFactoryTest.java
Thank you :-)
toehead2001
force-pushed
the
youtube-music
branch
from
cd8b8d8 to
b709529
Compare
Stypox
approved these changes
Sep 12, 2019
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Ok, all should be good now, thanks
This was referenced Sep 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to handle links coming from music.youtube.com.
Closes TeamNewPipe/NewPipe#1484