Basic PeerTube support (without P2P)#145
Merged
TobiGr merged 40 commits intoTeamNewPipe:devfrom Dec 2, 2019
Merged
Conversation
Contributor
yausername
commented
Mar 9, 2019
yausername
commented
- I carefully read the contribution guidelines and agree to them.
- I did test the API against NewPipe.
- I agree to ASAP create a PULL request for NewPipe for making in compatible when I changed the api.
- No P2P (video playback is via direct https link).
- No multi-instance support. Cannot use multiple instances simultaneously.
- Pre selected default instance - http://framatube.org/
- No login/accounts.
1 task
theScrabi
requested changes
Mar 23, 2019
extractor/src/main/java/org/schabi/newpipe/extractor/ServiceList.java
Outdated
Show resolved
Hide resolved
|
|
||
| import org.schabi.newpipe.extractor.MediaFormat; | ||
|
|
||
| public abstract class Stream implements Serializable { |
Member
There was a problem hiding this comment.
Could you plese add a jdoc documentation to this file, and explain the use of torrenturl :)
Contributor
Author
There was a problem hiding this comment.
done.
added example of the optional parameter torrentUrl (https://webtorrent.io/torrents/big-buck-bunny.torrent), supplied if the stream can be played via bittorrent.
|
Has the peertube api actually been changed since? |
theScrabi
approved these changes
Nov 21, 2019
Member
|
You've got my go. Code looks fine, and I didn't find anything where the api got broken :) |
Contributor
|
The validation process looks cleaner now 👍 |
TobiGr
approved these changes
Dec 2, 2019
Contributor
|
Yeah. Finally 🎉 Thank you ❤️ |
TobiGr
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.