[YouTube] Check whether player responses are valid for all InnerTube clients used #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You should change the Javadoc and the parameters of the method used, as it doesn't apply anymore to only additionnal player responses and YouTube return a different video error for the IP rate limit case. You should also change this behavior for the TV client we use. |
FireMasterK
force-pushed
the
player-response-failfast
branch
from
c8f9f4d to
f063dd1
Compare
AudricV
changed the title
AudricV
approved these changes
Jun 18, 2023
This was referenced Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in light of the recent YouTube changes.
Also removed unneeded empty string fallback when the
videoIdproperty in the player responses is missing.