"Unrevert" changes from pull request 6824#7348
Merged
litetex merged 1 commit intoTeamNewPipe:devfrom Nov 2, 2021
Merged
Conversation
PR 7061 reverted by mistake PR 6824 (it was a rebase issue). This commit unreverts this change and uses custom TextViews correctly in the file changed by PR 6824.
AudricV
added
bug
5 tasks
Member
Author
|
@tsiflimagas Can you confirm that the issue is fixed for you? Thank you in advance. |
Contributor
|
It seems fine to me, thank you for the fix! I hope there aren't other pieces of code which got reverted and didn't get discovered. |
Member
Author
|
I checked all my changes in my PR and this was the only strange change so I think there are no other places on which I did strange things. |
This was referenced Nov 30, 2021
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
#7061 reverted by mistake #6824 (it was a rebase issue). This PR "unreverts" this change and uses our custom
TextViewcorrectly in the file changed by #6824 (activity_player_queue_control.xml).Before/After Screenshots/Screen Record
Check the screenshots of #6824 to see the difference.
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence