-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Use NetCipher for handling TLS compatibility #7175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52d05bb to
cdead50
Compare
cdead50 to
5b9025a
Compare
5b9025a to
75bd5dc
Compare
Member
|
NewPipe doesn't start on my device (Pixel 4a, Android 11). |
Contributor
Author
|
I actually get the same error on Kitkat, so I still have work to do :D. I just did not came around to logcat the error until now. |
1 task
Member
|
Added the "wait-for-author" label since there is no progress since >=3 weeks. |
This was referenced Nov 4, 2021
Member
|
Superseded by #7372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
waiting for author
If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This (somewhat) fixes #2898 by using netcipher(https://guardianproject.info/code/netcipher/) for handling TLS connections. It has the nice benefit that we can remove a lot of code on our side for handling Android Kitkat.
A small downside is that Netcipher keeps TLS1.1 and 1.0 enabled for Android 19-23 at the moment while 1.0 was disabled for kitkat before, but I don't think this is a showstopper.
You may ask why I did not use the okhttp integration of netcipher: Would be far more complex to implement (we need a
Contextand anIntentwhich is only used for Tor integration inside netcipher)APK testing
app-debug.zip
These changes should be tested on all possible devices and versions as it impacts the whole connectivity on all platforms.
How to test? Check if the following things still work:
Due diligence