Fixed the navbar color for darkmode #7085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
approved these changes
Sep 9, 2021
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
LGTM!
I changed the branch to target the upcomming release.
TobiGr
added
bug
Member
|
Wait, why does the video in "After" not have the dark spash screen color? |
Member
Author
|
It is darker when the device darkmode is enabled: |
Member
|
@litetex oh ok, I see, sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
System.bar.dark.theme.mp4
NewOpeningNavColorFix.mp4
Fixes the following
This will fix the comment mentioned in #7066 (comment)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence