Skip to content

Conversation

@XiangRongLin
Copy link
Collaborator

What is it?

  • Codebase improvement (dev facing)

Description of the changes in your PR

  • Add gradle parameter to skip formatKtLint and use in CI

Screenshots

with parameter

image

without parameter it starts with formatKtLint

image

Fixes the following issue(s)

  • This way runKtlint is not executed twice during CI

Due diligence

@XiangRongLin XiangRongLin added the CI Everything related to CI (Continuous integration) label Aug 6, 2021
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XiangRongLin XiangRongLin merged commit c3b9465 into TeamNewPipe:dev Aug 7, 2021
@XiangRongLin XiangRongLin deleted the ci_ktlint branch August 7, 2021 10:36
This was referenced Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Everything related to CI (Continuous integration)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants