Skip to content

Conversation

@TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Aug 5, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fixed two warnings which I got while running the code inspection in Android Studio

  • Fixed link to Brazil README in Japanese README
  • Fixed redundant character class declaration in EMAIL_ADDRESS regex

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Stypox
Stypox previously approved these changes Aug 6, 2021
@TobiGr TobiGr changed the title Fix readme link and improve regex Fix readme link Dec 22, 2021
@XiangRongLin XiangRongLin merged commit 19dd9d2 into dev Dec 23, 2021
@TobiGr TobiGr deleted the fix/inspection branch December 23, 2021 11:21
This was referenced Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants