Skip to content

Conversation

@K0-RR
Copy link
Contributor

@K0-RR K0-RR commented Aug 2, 2021

What is it?

  • Meta improvement to the project (dev facing) I THINK
  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)

Description of the changes in your PR

Lossless compression. I used oxipng.

Before/After Screenshots/Screen Record

No visual differences

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Lossless compression.
@Stypox
Copy link
Member

Stypox commented Aug 3, 2021

What is the APK size difference?

@triallax
Copy link
Contributor

triallax commented Aug 3, 2021

@Stypox I'll check and come back with the results.

@triallax
Copy link
Contributor

triallax commented Aug 3, 2021

I built a release APK for each of this PR's commit and the previous commit. This PR's APK is 8904298 bytes long, while the previous APK is 8906273 bytes long, a difference of around 2 kilobytes.

Copy link
Contributor

@triallax triallax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it may not be worth it to minify anything not included in the APK, as I believe it would increase the Git repo's size, as Git does not store diffs of binary files (correct me if I'm wrong though).

@TobiGr
Copy link
Contributor

TobiGr commented Aug 3, 2021

Minimizing the screenshots makes sense to me, because that results in faster loading of the readme

@Stypox
Copy link
Member

Stypox commented Aug 4, 2021

Minimizing the screenshots makes sense to me, because that results in faster loading of the readme

Also to me, I'd merge this

@triallax triallax merged commit 26c3938 into TeamNewPipe:dev Aug 4, 2021
@triallax
Copy link
Contributor

triallax commented Aug 4, 2021

@RDKRACZ thanks!

@K0-RR K0-RR deleted the oxi branch August 4, 2021 12:23
spvkgn pushed a commit to spvkgn/NewPipe that referenced this pull request Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants