Skip to content

Conversation

@litetex
Copy link
Member

@litetex litetex commented Jul 30, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

We had quite some discussion in #6709. This PR is the successor.

Run ktlint before building on the CI.

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@litetex litetex mentioned this pull request Jul 30, 2021
5 tasks
@litetex
Copy link
Member Author

litetex commented Jul 30, 2021

@XiangRongLin
Can I merge the PR?

@Stypox Stypox merged commit a25bb26 into TeamNewPipe:dev Jul 31, 2021
@litetex litetex deleted the ci-run-format-ktlin-before-building branch July 31, 2021 14:43
This was referenced Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check for uncommited changes (like formatting problems with kotlin files)

3 participants