Use WindowInsetsCompat's getInsets() method.#6689
Merged
Stypox merged 1 commit intoTeamNewPipe:devfrom Jul 19, 2021
Merged
Conversation
AudricV
added
the
codequality
triallax
reviewed
Jul 18, 2021
Isira-Seneviratne
force-pushed
the
Use_WindowInsetsCompat_getInsets
branch
from
97533b1 to
1721817
Compare
Stypox
approved these changes
Jul 19, 2021
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Code looks good; I tested with my no-cutout phone and with all kinds of emulated cutouts on API 30 emulator and I noticed no problems. Thanks :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
WindowInsetsCompat'sgetInsetsmethod to get the display cutout insets.APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence