Skip to content

Increase width of metadata text view#6438

Merged
TobiGr merged 2 commits intodevfrom
fix/metadataView
Jun 7, 2021
Merged

Increase width of metadata text view#6438
TobiGr merged 2 commits intodevfrom
fix/metadataView

Conversation

@TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Jun 6, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Increase width of metadata text view.
Some translations come with longer words causing them to wrap at strange positions

Screenshots

Before After
Screenshot_1623003898 Screenshot_1623003780

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

TobiGr added 2 commits June 6, 2021 11:57
Some translations come with longer words causing them to wrap at strange positions
@TobiGr TobiGr added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Jun 6, 2021
@TobiGr TobiGr changed the title Fix/metadata view Increase width of metadata text view Jun 6, 2021
@opusforlife2
Copy link
Collaborator

Does this have to be a dev estimated value? Can it not be made dynamic?

@Stypox
Copy link
Member

Stypox commented Jun 6, 2021

It is already dynamically set to 30%. Changing even automatically this value to a bigger one will let only a small amount of space on the right, which is bad

@B0pol
Copy link
Member

B0pol commented Jun 6, 2021

Screenshot before after please

@TobiGr TobiGr changed the base branch from dev to release_0.21.4 June 7, 2021 17:20
@TobiGr TobiGr changed the base branch from release_0.21.4 to dev June 7, 2021 17:27
@TobiGr TobiGr merged commit 509f501 into dev Jun 7, 2021
@TobiGr TobiGr deleted the fix/metadataView branch June 7, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug GUI Issue is related to the graphical user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants