Save backup import/export location for future import/exports#6319
Save backup import/export location for future import/exports#6319XiangRongLin merged 6 commits intoTeamNewPipe:devfrom
Conversation
XiangRongLin
left a comment
There was a problem hiding this comment.
Did you cover the edge case that i mentioned in the issue?
app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java
Outdated
Show resolved
Hide resolved
Yes, I have tried to cover it in |
app/src/test/java/org/schabi/newpipe/util/FilePathHelperTest.java
Outdated
Show resolved
Hide resolved
Not that i can think of |
|
Can you also remove the conversions between file and path in your tests. Like this XiangRongLin@376e5c1 |
Yes, I merge your branch with mine. |
XiangRongLin
left a comment
There was a problem hiding this comment.
Codewise looks fine to me now.
|
I don't know how to rebase #5415 on top of this... I think that storing the last used path would require some more work in |
TeamNewPipe#6319 and TeamNewPipe#6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
TeamNewPipe#6319 and TeamNewPipe#6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
TeamNewPipe#6319 and TeamNewPipe#6402 were reverted before adding SAF changes, and have been readded at the end of SAF changes
What is it?
Description of the changes in your PR
To save location of import/export, I add a new preference key for
import_export_pathand save this preference on result of file chooser activity and send it on intent of file chooser on later tries.So as a user, If a export data on folder
foo, when I want to import this data, file chooser showfooas start path.Fixes the following issue(s)
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence