Skip to content

feat: delete playlist item on swipe#6318

Closed
Hamedamz wants to merge 1 commit intoTeamNewPipe:devfrom
Hamedamz:feat-delete-playlist-item-on-swipe
Closed

feat: delete playlist item on swipe#6318
Hamedamz wants to merge 1 commit intoTeamNewPipe:devfrom
Hamedamz:feat-delete-playlist-item-on-swipe

Conversation

@Hamedamz
Copy link

swipe a playlist item to left to delete it

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • add swipe gesture to the playlist items
  • swipe a playlist item to left to delete it

Fixes the following issue(s)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

deleteOnSwipe

swipe a playlist item to left to delete it
@Hamedamz Hamedamz changed the title feat: delete playlist item on swipe (#6187) feat: delete playlist item on swipe May 17, 2021
@XiangRongLin
Copy link
Collaborator

The UI get buggy if you do some monkey testing. I selected an item and repeatedly swiped left to right and repeat. I somehow managed to delete the item, but the red background stayed, but i could not reproduce it for the video. What you can see is the trash icon overlapping the 2 lines on the right.

newpipe.mp4

Some sort of cue would be good when one has swiped far enough that the item will be deleted. I remember reading the android design docs, that a haptic feedback could be given, but i personally really dislike vibration. But thats a minor thing

@XiangRongLin
Copy link
Collaborator

Also because deletion is now very easy to do compared to before, a snackbar with a generic deletion message and an undo button would be appropiate.
When one deletes multiple entries quickly in succession, previous snackbars need to be dismissed. So they don't stack up

@TobiGr
Copy link
Contributor

TobiGr commented May 21, 2021

please be aware that deleting by swing to left or right can be a problem when these fragments are used on the main page, because there are two identical vertical swipe gestures with different behaviour. IIRC, we dismissed a similar PR a few years ago for the same reason. The bahaviour needs to be tested on the main page and maybe swipe to delete disabled when useAsFrontPage is true. (btw. that var needs to be renamed to something like isUsedInMainView)

@triallax triallax added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels May 29, 2021
@Angelk90
Copy link
Contributor

@Hamedamz , @XiangRongLin, @TobiGr : Is there any news on this?

@XiangRongLin
Copy link
Collaborator

I would say this PR should be closed, since the contributor seems to have abandoned it.

@Stypox Stypox closed this Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Swipe to delete item from History/Playlists

6 participants