feat: delete playlist item on swipe#6318
Conversation
swipe a playlist item to left to delete it
|
The UI get buggy if you do some monkey testing. I selected an item and repeatedly swiped left to right and repeat. I somehow managed to delete the item, but the red background stayed, but i could not reproduce it for the video. What you can see is the trash icon overlapping the 2 lines on the right. newpipe.mp4Some sort of cue would be good when one has swiped far enough that the item will be deleted. I remember reading the android design docs, that a haptic feedback could be given, but i personally really dislike vibration. But thats a minor thing |
|
Also because deletion is now very easy to do compared to before, a snackbar with a generic deletion message and an undo button would be appropiate. |
|
please be aware that deleting by swing to left or right can be a problem when these fragments are used on the main page, because there are two identical vertical swipe gestures with different behaviour. IIRC, we dismissed a similar PR a few years ago for the same reason. The bahaviour needs to be tested on the main page and maybe swipe to delete disabled when |
|
@Hamedamz , @XiangRongLin, @TobiGr : Is there any news on this? |
|
I would say this PR should be closed, since the contributor seems to have abandoned it. |
swipe a playlist item to left to delete it
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence