Skip to content

Fix ErrorActivity actionbar back button not working#6312

Merged
XiangRongLin merged 1 commit intoTeamNewPipe:devfrom
ATofighi:fix-6298-report-page-back-not-working
May 17, 2021
Merged

Fix ErrorActivity actionbar back button not working#6312
XiangRongLin merged 1 commit intoTeamNewPipe:devfrom
ATofighi:fix-6298-report-page-back-not-working

Conversation

@ATofighi
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • change back button id from app id to android id

Fixes the following issue(s)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

The issue is because of R.id.home != android.R.id.home
@ATofighi ATofighi marked this pull request as ready for review May 15, 2021 21:52
@TobiGr TobiGr added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels May 15, 2021
@XiangRongLin XiangRongLin merged commit e0b2464 into TeamNewPipe:dev May 17, 2021
@ATofighi ATofighi deleted the fix-6298-report-page-back-not-working branch May 17, 2021 15:57
This was referenced May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug GUI Issue is related to the graphical user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Back button does nothing on Error Report page

3 participants