Skip to content

Add workaround for PeerTube HLS streams#6307

Merged
TobiGr merged 1 commit intodevfrom
peertube_hls
May 23, 2021
Merged

Add workaround for PeerTube HLS streams#6307
TobiGr merged 1 commit intodevfrom
peertube_hls

Conversation

@TobiGr
Copy link
Contributor

@TobiGr TobiGr commented May 15, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Get the duration form the currrent play queue item instead of the player itself if possible. HLS streams do not always come with info on the stream length, so this info get be retrieved from the current play queue item.

ToDo

  • Test behaviour with live streams.

Fixes the following issue(s)

Relies on the following changes

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@TobiGr TobiGr added bug Issue is related to a bug peertube Service, https://joinpeertube.org/ player Issues related to any player (main, popup and background) labels May 15, 2021
@TobiGr TobiGr mentioned this pull request May 15, 2021
4 tasks
@TobiGr TobiGr force-pushed the peertube_hls branch 2 times, most recently from 85a44b9 to 173b8c8 Compare May 15, 2021 10:43
@opusforlife2
Copy link
Collaborator

Now the player shows the correct video length.

But seeking still doesn't work. It just jumps back to whatever timestamp has been loaded.

@TILvids
Copy link

TILvids commented May 15, 2021

@TobiGr Thanks for looking into this, as we have had users wondering why NewPipe no longer "works" with tilvids.com!

I downloaded the build you requested and tested it out. The videos from our instance definitely play now, so that's good progress! I did see issues seeking around like @opusforlife2 mentioned, so that's probably something to look into. But looks like it's off to a good start, and people can actually view videos now!

@TILvids
Copy link

TILvids commented May 18, 2021

FWIW, I'd still recommend merging this, because at least HLS-transcoded videos play now, which is a huge improvement over not playing at all. I'd file the seeking issue as a separate bug, and merge this in.

@opusforlife2
Copy link
Collaborator

opusforlife2 commented May 18, 2021

When the next RC is due to be published, then we can merge this and postpone that fix. But until then, there is still time to look for a solution.

@TobiGr TobiGr merged commit f0bb2e8 into dev May 23, 2021
@TobiGr TobiGr deleted the peertube_hls branch May 23, 2021 10:07
@TobiGr TobiGr changed the title Add support for PeerTube HLS streams Add workaround for PeerTube HLS streams May 23, 2021
This was referenced May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug peertube Service, https://joinpeertube.org/ player Issues related to any player (main, popup and background)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for PeerTube HLS videos

3 participants