Conversation
85a44b9 to
173b8c8
Compare
|
Now the player shows the correct video length. But seeking still doesn't work. It just jumps back to whatever timestamp has been loaded. |
|
@TobiGr Thanks for looking into this, as we have had users wondering why NewPipe no longer "works" with tilvids.com! I downloaded the build you requested and tested it out. The videos from our instance definitely play now, so that's good progress! I did see issues seeking around like @opusforlife2 mentioned, so that's probably something to look into. But looks like it's off to a good start, and people can actually view videos now! |
|
FWIW, I'd still recommend merging this, because at least HLS-transcoded videos play now, which is a huge improvement over not playing at all. I'd file the seeking issue as a separate bug, and merge this in. |
|
When the next RC is due to be published, then we can merge this and postpone that fix. But until then, there is still time to look for a solution. |
What is it?
Description of the changes in your PR
Get the duration form the currrent play queue item instead of the player itself if possible. HLS streams do not always come with info on the stream length, so this info get be retrieved from the current play queue item.
ToDo
Fixes the following issue(s)
Relies on the following changes
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence