Skip to content

Generalised/tense-corrected the example#6302

Merged
triallax merged 2 commits intoTeamNewPipe:devfrom
goyalyashpal:patch-1
May 15, 2021
Merged

Generalised/tense-corrected the example#6302
triallax merged 2 commits intoTeamNewPipe:devfrom
goyalyashpal:patch-1

Conversation

@goyalyashpal
Copy link
Contributor

@goyalyashpal goyalyashpal commented May 14, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Updated the tense of the example so that it aligns with the general case it's intended to point to. it helps to avoid misunderstanding about current distribution status.

Fixes the following issue(s)

  • Fixes #

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@opusforlife2
Copy link
Collaborator

The text in brackets is a hypothetical example of something that might happen every now and then, not a reference to the one particular incident you're thinking of where Newpipe was stuck on an old version on F-Droid. So the current version is correct and there is no change needed.

But thanks for the thought, Yash. ;)

@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented May 14, 2021

/close ?
edit: oh wait no

Grammaticised and Generalised the wording

Co-authored-by: opusforlife2 <[email protected]>
Copy link
Contributor

@triallax triallax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not merging right now to know @opusforlife2's and possibly others' opinions.

@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented May 15, 2021

LGTM ?

@triallax
Copy link
Contributor

It means "looks good to me."

@opusforlife2
Copy link
Collaborator

There's also the classic "LGTM to me!".

@yashpalgoyal1304 Please change the title and body, as this PR is now doing something completely different.

@mhmdanas It's asking me to approve and run the workflow. Is it okay to do that at any point or is there something to look out for?

Feel free to merge this after he changes the title and body.

@triallax

This comment has been minimized.

@opusforlife2

This comment has been minimized.

@triallax

This comment has been minimized.

@goyalyashpal goyalyashpal changed the title Fixed Tense of the fdroid incident Generalised/tense-corrected the example May 15, 2021
@goyalyashpal
Copy link
Contributor Author

change t & b

done

@triallax triallax merged commit 2d4a3c2 into TeamNewPipe:dev May 15, 2021
@triallax
Copy link
Contributor

Thanks!

@AudricV AudricV added the meta Related to the project but not strictly to code label May 20, 2021
@goyalyashpal goyalyashpal deleted the patch-1 branch May 20, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Related to the project but not strictly to code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants