Add debug option to disable media tunneling#6288
Merged
TobiGr merged 3 commits intoTeamNewPipe:devfrom May 14, 2021
Merged
Conversation
4 tasks
TobiGr
reviewed
May 14, 2021
| <string name="show_memory_leaks_key" translatable="false">show_memory_leaks_key</string> | ||
| <string name="allow_disposed_exceptions_key" translatable="false">allow_disposed_exceptions_key</string> | ||
| <string name="show_original_time_ago_key" translatable="false">show_original_time_ago_text_key</string> | ||
| <string name="disable_media_tunneling_key" translatable="false">disable_media_tunneling_text_key</string> |
Contributor
There was a problem hiding this comment.
What's the reason for using a different value here?
Suggested change
| <string name="disable_media_tunneling_key" translatable="false">disable_media_tunneling_text_key</string> | |
| <string name="disable_media_tunneling_key" translatable="false">disable_media_tunneling_key</string> |
Member
Author
There was a problem hiding this comment.
was asking that myself. I was just copying from <string name="show_original_time_ago_key" translatable="false">show_original_time_ago_text_key</string>
Member
Author
There was a problem hiding this comment.
I have removed it from both
Contributor
There was a problem hiding this comment.
if you change the key value, we might want to add a SettingsMigration. I am not sure if this a bit too much effort for a rarely used debug setting.
Member
Author
There was a problem hiding this comment.
yes, I would say that a migration is not required. But out of curiosity, is there a concept for it in Android and/or do we already have a settings migration in NewPipe?
TobiGr
added
the
player
TobiGr
approved these changes
May 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Added an option for DEBUG builds only to help users to check if their issues with video (blackscreen or stuttering) are a cause of not working media tunneling on their device / custom os.
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence