Skip to content

Conversation

@aliraad79
Copy link

@aliraad79 aliraad79 commented May 14, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • add a new function in PlaylistRemoteEntity
  • use the upper function in RemotePlaylistItemHolder
  • Instead of showing long strings in name that is not necessary we show 35 character of name ending with three dots.

Fixes the following issue(s)

APK testing

  • I don't get this part :)

Due diligence

@opusforlife2
Copy link
Collaborator

@aliraad79 Please edit your issue body to reflect what the PR is doing, instead of just listing the code changes you made. Those are fine to mention in the details, but they can't be the only thing in your description.

Also, the issue title is too long and is also cut off. Please make it shorter.

}

public String getShortedUploaderName() {
return uploader.substring(0, Math.min(uploader.length(), 35)) + "...";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, this will always show the ellipsis, which is definitely not something that we want.

@aliraad79
Copy link
Author

Thanks for all of your fast comments. I fix this things in a new commit

@aliraad79 aliraad79 changed the title fix long uploader name which results in not seeing service name in bo… slice long names May 15, 2021
@aliraad79 aliraad79 changed the title slice long names handle long names in different places May 15, 2021
@opusforlife2
Copy link
Collaborator

@aliraad79 Thanks. Could you add a couple of screenshots to show how it looks now?

@Stypox
Copy link
Member

Stypox commented Jun 8, 2021

This has to be fixed by changing the layout and setting ellipsize, not by truncating the string with code.

@litetex litetex marked this pull request as draft October 2, 2021 15:28
@litetex
Copy link
Member

litetex commented Oct 2, 2021

I'm closing this PR for now:

Feel free to reopen it when there is further progress.

@litetex litetex closed this Oct 2, 2021
@litetex litetex mentioned this pull request Oct 10, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long channel names move service name off the screen

5 participants