Skip to content

fix Rotation crash on „Video not available“ page (#5941) #6242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TobiGr merged 1 commit into from
Jun 3, 2021
Merged

fix Rotation crash on „Video not available“ page (#5941) #6242

TobiGr merged 1 commit into from
Jun 3, 2021

Conversation

@evermind-zz
Copy link
Contributor

@evermind-zz evermind-zz commented May 5, 2021 •
edited by opusforlife2
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • The EmptyFragment should not have a constructor at all.
  • Now a static methods creates the Fragment and arguments are handled via a Bundle.

Fixes the following issue(s)

Due diligence

@evermind-zz
fix Rotation crash on „Video not available“ page (TeamNewPipe#5941)
a012e26 
The EmptyFragment should not have a constructor at all.
Now a static methods creates the Fragment and arguments
are handled via a Bundle.
@TobiGr
Copy link
Contributor

TobiGr commented May 5, 2021

Thank you! This seems to fix the crash, but unfortunately not the underlying bug.
Ensure to have slow internet. Open a video page, wait until the video starts playing. Then tap on a related stream and rotate the phone immediately. You'll be back on the video page you were before. Some states are not saved or restored correctly.

@TobiGr TobiGr added the bug Issue is related to a bug label May 5, 2021
@TobiGr TobiGr merged commit f98d263 into TeamNewPipe:dev Jun 3, 2021
@SameenAhnaf SameenAhnaf mentioned this pull request Jun 3, 2021
Closed
4 tasks
@peat80 peat80 mentioned this pull request Jun 4, 2021
Closed
4 tasks
This was referenced Jun 5, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees

No one assigned

Labels

bug Issue is related to a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rotation crash on „Video not available“ page

2 participants

@evermind-zz @TobiGr