Conversation
TobiGr
added
feature request
fynngodau
previously approved these changes
Apr 11, 2021
Member
fynngodau
left a comment
fynngodau
left a comment
There was a problem hiding this comment.
I tested this one, too, and it works well. Please see my comments; other than that it looks good.
Display channel / creator / artist name when given
TobiGr
force-pushed
the
bandcamp_segments
branch
from
d17cefe to
e5457e5
Compare
fynngodau
approved these changes
Apr 12, 2021
Member
fynngodau
left a comment
fynngodau
left a comment
There was a problem hiding this comment.
My review has been addressed 👍
Collaborator
|
Will the heading still be "Chapters" on Bandcamp? What about something like "Streams", or "Tracks"? |
Contributor
Author
|
@opusforlife2 I don't have time for that. Maybe someone else can do that. Please open an issue for that. |
3 tasks
Collaborator
|
Done. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Display channel / creator / artist name in stream segment list when available.
Relies on the following changes
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence