Skip to content

Fix NullPointerException: Attempt to get length of null array in MainActivity #5999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Redirion merged 8 commits into from
Apr 6, 2021
Merged

Fix NullPointerException: Attempt to get length of null array in MainActivity #5999

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
12d9cf0
Overlapping fonts #5096
wangear Mar 12, 2021
b5ce2eb
Overlapping fonts #5096
wangear Mar 13, 2021
fb02db7
Overlapping fonts #5096
wangear Mar 23, 2021
bd25eff
Overlapping fonts #5096
wangear Mar 23, 2021
875ed82
Crash on tapping anywhere on video after long-pressing 'Popup' button…
wangear Mar 31, 2021
97d45a0
Merge pull request #1 from TeamNewPipe/dev
wangear Mar 31, 2021
32b03bd
Merge pull request #2 from TeamNewPipe/dev
wangear Apr 4, 2021
34f2054
Fixed Unable to start activity ComponentInfo{org.schabi.newpipe/org.s…
wangear Apr 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions app/src/main/java/org/schabi/newpipe/util/StateSaver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ public static void init(final Context context) {
}

/**
* @see #tryToRestore(SavedState, WriteRead)
* @param outState
* @param writeRead
* @return the saved state
* @see #tryToRestore(SavedState, WriteRead)
*/
public static SavedState tryToRestore(final Bundle outState, final WriteRead writeRead) {
if (outState == null || writeRead == null) {
Expand All @@ -93,6 +93,7 @@ public static SavedState tryToRestore(final Bundle outState, final WriteRead wri
/**
* Try to restore the state from memory and disk,
* using the {@link StateSaver.WriteRead#readFrom(Queue)} from the writeRead.
*
* @param savedState
* @param writeRead
* @return the saved state
Expand Down Expand Up @@ -143,19 +144,18 @@ private static SavedState tryToRestore(@NonNull final SavedState savedState,
}

/**
* @see #tryToSave(boolean, String, String, WriteRead)
* @param isChangingConfig
* @param savedState
* @param outState
* @param writeRead
* @return the saved state or {@code null}
* @see #tryToSave(boolean, String, String, WriteRead)
*/
@Nullable
public static SavedState tryToSave(final boolean isChangingConfig,
@Nullable final SavedState savedState, final Bundle outState,
final WriteRead writeRead) {
@NonNull
final String currentSavedPrefix;
@NonNull final String currentSavedPrefix;
if (savedState == null || TextUtils.isEmpty(savedState.getPrefixFileSaved())) {
// Generate unique prefix
currentSavedPrefix = System.nanoTime() - writeRead.hashCode() + "";
Expand Down Expand Up @@ -299,8 +299,11 @@ public static void clearStateFiles() {

cacheDir = new File(cacheDir, CACHE_DIR_NAME);
if (cacheDir.exists()) {
for (final File file : cacheDir.listFiles()) {
file.delete();
final File[] list = cacheDir.listFiles();
if (list != null) {
for (final File file : list) {
file.delete();
}
}
}
}
Expand Down