Do not set reCaptcha cookie when there is no cookie stored#5997
Merged
Conversation
In DownloaderImpl#getCookies(String url) the reChaptcha cookie is set if it is not null. For this reason, the cookie was set in every request.
TobiGr
added
the
privacy & data protection
B0pol
changed the title
opusforlife2
changed the title
Member
|
Looks plain simple and easy. Anything we are waiting for? Should be good to merge. |
Collaborator
|
@Redirion Can't you then just merge it? You have the rights to approve and merge it |
Member
|
but TobiGr requested a review from Stypox. So there could be more into it that requires (regional) testing |
Contributor
Author
|
we should merge this. I requested a review from Stypoc, because he has a very good overview of the whole reChaptcha mechanism implemented in NewPipe. I think, this should be good to merge. |
XiangRongLin
approved these changes
May 4, 2021
Stypox
approved these changes
May 4, 2021
This was referenced May 6, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
choose the correct default value when getting the reChaptcha cookie from the preferences.
In DownloaderImpl#getCookies(String url) the reChaptcha cookie is set if it is not null. For this reason, the cookie was set in every request.
Fixes the following issue(s)
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence