Add functionality to rename Playlist Name from playlist interface#5982
Merged
Redirion merged 2 commits intoTeamNewPipe:devfrom Apr 1, 2021
Merged
Add functionality to rename Playlist Name from playlist interface#5982Redirion merged 2 commits intoTeamNewPipe:devfrom
Redirion merged 2 commits intoTeamNewPipe:devfrom
Conversation
Member
|
thanks for your contribution! However I don't understand why you did basically add doubled code. What was the reason not to use createRenameDialog() ? Also please refrain from using hardcoded text, use String resources please so that text can be translated. |
Contributor
Author
|
Thanks for the information. I have updated the code accordingly. |
Member
|
@Redirion I've assigned this to you, feel free to merge if you think it is ready. Code looks fine to me, but I did not test. |
Member
|
tested, works. @PulkitGarg67 can you squash your two commits into one? git reset --soft HEAD~2 |
Member
|
@Redirion you can squash and merge via GitHub |
Redirion
approved these changes
Apr 1, 2021
This was referenced Apr 11, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence