Skip to content

Conversation

@sauravrao637
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • check if the binding is null before attempting to retrieve its objects.

Fixes the following issue(s)

Relies on the following changes

  • Could not reproduce the bug even after several attempts to do so thus had to rely on crash report provided with the issue which clearly shows Attempt to read from field 'androidx.viewpager.widget.ViewPager org.schabi.newpipe.databinding.FragmentVideoDetailBinding.viewPager' on a null object reference thus we add a check for null value for binding before accessing its objects

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and sorry for being nitpicking :-D

@Stypox Stypox merged commit 8df935f into TeamNewPipe:dev Apr 1, 2021
@sauravrao637
Copy link
Contributor Author

@Stypox Thanks for helping out and it's fine ,I am new here so would love to learn and suggestions are always welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NullPointerException on screen rotation during exit

2 participants