Fix hidden icon to the left of notification actions in settings #5935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triallax
added
bug
Contributor
|
Sorry, I was going to download the APK to test this but re-ran the workflow by mistake. Edit: looks like I messed up. I tried to cancel the workflow, but it's been queued for almost 14 minutes. @Stypox can you push an empty commit or something? |
Member
Author
|
@mhmdanas I just re-ran all checks again and it seems to have worked |
triallax
approved these changes
Mar 31, 2021
Contributor
triallax
left a comment
triallax
left a comment
There was a problem hiding this comment.
I can confirm that this works; somebody else should take a look at the code changes.
TobiGr
approved these changes
Mar 31, 2021
This was referenced Apr 11, 2021
Closed
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 23, 2021
…ion-settings Fix hidden icon to the left of notification actions in settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Even though the
ConstraintLayoutcode seemed right, for some reason the icon to left of the five notification actions under "Settings -> Notification" has width0dpand were thus invisible. I don't know when this happened, they were working when the PR about notifications was merged, but nevermind. This fixes it by setting a constant width instead of a constant height, and for some reason only this waylayout_constraintDimensionRatio="1"does its job forcing the image into a square.APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence