Skip to content

Fix error panel created in onViewCreated() but disposed in onDestroy() #5896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TobiGr merged 1 commit into from
Mar 24, 2021
Merged

Fix error panel created in onViewCreated() but disposed in onDestroy() #5896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions app/src/main/java/org/schabi/newpipe/fragments/BaseStateFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,6 @@ public void onResume() {
}
}

@Override
public void onDestroy() {
super.onDestroy();
errorPanelHelper.dispose();
}

/*//////////////////////////////////////////////////////////////////////////
// Init
//////////////////////////////////////////////////////////////////////////*/
Expand All @@ -74,6 +68,14 @@ protected void initViews(final View rootView, final Bundle savedInstanceState) {
errorPanelHelper = new ErrorPanelHelper(this, rootView, this::onRetryButtonClicked);
}

@Override
public void onDestroyView() {
super.onDestroyView();
if (errorPanelHelper != null) {
errorPanelHelper.dispose();
}
}

protected void onRetryButtonClicked() {
reloadContent();
}
Expand Down