Add channel details option to long-press menu

[triallax]

What is it?

• Feature (user facing)

Description of the changes in your PR

Add option to open channel details page when long-pressing items.

Fixes the following issue(s)

• Fixes Longpress (menu) option for direct channel videos overview access (tablet optimisation) #5447.

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

• I read the contribution guidelines.

[Stypox]

Maybe try with getParentFragmentManager()

[triallax]

Unfortunately that doesn't fix the issue.

[Stypox]

With fragment.getActivity().getSupportFragmentManager() it works (this is strange, though)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

0.0% Coverage
0.0% Duplication

[Stypox]

@mhmdanas please fix the issues pointed out by Sonar

[triallax]

I fixed the braces "code smell," but kept the other two because one is a TODO and the other is because I'm following the naming convention of the rest of the file.

[Stypox]

Do you think this can be merged even though there is an unsolved TODO?

[triallax]

I searched quite a bit and failed to find any explanation. Can I just replace the TODO comment with something like "For some reason getParentFragmentManager() doesn't work, but this does"?

[Stypox]

Can I just replace the TODO comment with something like "For some reason getParentFragmentManager() doesn't work, but this does"?

@mhmdanas ok, that's fine

[Stypox]

Thanks :-)

[opusforlife2]

This option doesn't appear in the Feeds (What's New or any other). Known issue? Postponed?

[triallax]

@opusforlife2 not known, at least to me.

The only way that would happen is if calling getUploaderUrl on the feed items returns null, which may sound unlikely, but is the only possibility here. I'll investigate later.

Edit: what service did you reproduce that on? Or is it all of them?

[opusforlife2]

what service did you reproduce that on?

I tried it with a feed with only YouTube channels in it. I haven't tried it with any other service.

[triallax]

The reason why this doesn't work with feeds is because the database doesn't store the feed items' uploader URLs. I don't think going back through all the feed items in feeds like "What's New" to add the uploader URL is a good idea. Maybe we could only add the URLs for new feed items? Anyway, I'll open an issue to continue the discussion there.

[opusforlife2]

@mhmdanas Please ping me in that issue so I can follow it when you open one.

[opusforlife2]

Maybe we could only add the URLs for new feed items?

Yeah, adding them when the user initiates a feed refresh seems like a practical solution.

[triallax]

To be clear, I did not mean to add it for all previous feed items, but only for new ones (i.e. ones added in a feed refresh).

[opusforlife2]

I got what you meant. We're on the same frequency. :3

[Plugdemholes-Imeanpatchdembugs]

@mhmdanas
Thanks for the implementation.
Usage has become far more frictionless than ever before since the implementation! :D