Skip to content

Conversation

@TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Mar 16, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Add sonar plugin and github actions file for sonar analysis
  • Copied from sonarcloud.io setup page with minor adjustments. Adjusted branch to 'dev' and updated versions

Fixes the following issue(s)

Relies on the following changes

Due diligence

@TobiGr
Copy link
Contributor Author

TobiGr commented Mar 16, 2021

I don't understand the result, but maybe that needs to be configured first. @XiangRongLin

@XiangRongLin
Copy link
Collaborator

For PRs it should only show results for files that were changed. So since no code was changes, it shows that everything is perfect

@TobiGr
Copy link
Contributor Author

TobiGr commented Mar 17, 2021

The checkstyle changes work for JDK 8, so this should be good to merge.

@XiangRongLin
Copy link
Collaborator

@TobiGr see the initial post. another thing needs to be done first

@AudricV AudricV added the meta Related to the project but not strictly to code label Mar 18, 2021
Copied from sonarcloud.io setup page with minor adjustments. Adjusted branch to 'dev' and updated versions
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@XiangRongLin XiangRongLin merged commit ea1b425 into dev Mar 20, 2021
@XiangRongLin XiangRongLin deleted the sonar_workflow branch March 20, 2021 17:48
This was referenced Mar 21, 2021
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Related to the project but not strictly to code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SonarQube] Add workflow file for analysis and adjust gradle file

4 participants