Fix last resize mode not being restored correctly#5792
Merged
Conversation
TobiGr
added
bug
I think the settings key "last_resize_mode" is ambiguous. While it is used to get the recently used resize mode, someone thought while working on the resize mode switcher, that the old (to be replaced) resize mode should be stored. Fixes #5613
develop1st
approved these changes
Mar 9, 2021
|
I found a temporary fix on my Redmi 8 and Samsung Galaxy Tab A6. What you need to do to keep it on the setting you want is to set the aspect ratio to the one that appears after what you want (For example if you want "Fill" set it to "Zoom") and then close the video. Open any video and it will be set to your preferred aspect ratio. This should still be fixed though, I'm just letting everyone know |
iamthesenate1
approved these changes
Mar 10, 2021
Contributor
iamthesenate1
left a comment
iamthesenate1
left a comment
There was a problem hiding this comment.
Works great for me.
TobiGr
force-pushed
the
dev
branch
2 times, most recently
from
679bc75 to
2aeccc0
Compare
ghost
mentioned this pull request
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 22, 2021
Fix last resize mode not being restored correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
The player's resize mode / aspect ratio handling was not stored correctly. For this reason, the resize mode needed to be changed every time the player was started on devices with aspect ratios different to 16:9.
I think the settings key "last_resize_mode" is ambiguous. While it is used to get the recently used resize mode, someone working on the resize mode switcher thought, that the old (to be replaced) resize mode should be stored.
I did not create a settings migration for this change, because we do not know which preferences were affected by this bug, and which were not.
Fixes the following issue(s)
Fixes #5613
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence