Skip to content

Implement "pause/play" toggle on hardware keyboard space button. #5562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TobiGr merged 2 commits into from
Mar 14, 2021
Merged

Implement "pause/play" toggle on hardware keyboard space button. #5562

TobiGr merged 2 commits into from
Mar 14, 2021

Conversation

@mbarashkov
Copy link

@mbarashkov mbarashkov commented Feb 12, 2021 •
edited by TobiGr
Loading

What is it?

  • Feature (user facing)

Description of the changes in your PR

  • When in full-screen video playback, hardware keyboard Space button will toggleplay/pause. This is done by focusing the play / pause button automatically.

Due diligence

@triallax triallax added the feature request Issue is related to a feature in the app label Feb 20, 2021
@TobiGr TobiGr added the player Issues related to any player (main, popup and background) label Mar 14, 2021
@TobiGr TobiGr merged commit 8271409 into TeamNewPipe:dev Mar 14, 2021
@TobiGr
Copy link
Contributor

TobiGr commented Mar 14, 2021

thank you

This was referenced Mar 21, 2021
Merged
Closed
@ghost ghost mentioned this pull request Apr 11, 2021
Open
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 21, 2021
@TobiGr @tossj
Merge pull request TeamNewPipe/NewPipe#5562 from mbarashkov/hardware_…
217afa9 
…keyboard_space_shortcut_v2

Implement "pause/play" toggle on hardware keyboard space button.
@bam2000
Copy link

bam2000 commented May 6, 2021

Hey, sorry for opening this topic but I guess this is the reason I’m getting crazy.
Can we please get an option to disable this feature ?
Reason: I’m using a shield tv with the shield remote and when I watched some newpipe switch to an app smarttv client for twitch to watch twitch on my shield and then I press the play pause button to pause the twitch stream newpipe starts playing in the background.

so please give us an option to disable this, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees

No one assigned

Labels

feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mbarashkov @TobiGr @bam2000 @triallax