removed resizing text from popup player#5554
Merged
XiangRongLin merged 2 commits intodevfrom Feb 15, 2021
unknown repository
Merged
removed resizing text from popup player#5554XiangRongLin merged 2 commits intodevfrom unknown repository
XiangRongLin merged 2 commits intodevfrom
unknown repository
Conversation
ghost
changed the title
Collaborator
|
Could you add before/after images? |
Author
|
First one is before. Text "Resizing" is shown in top left corner while you resizing the pop-up window with two fingers. |
triallax
changed the title
XiangRongLin
approved these changes
Feb 13, 2021
Collaborator
|
Thank you. After the current release is done, this can be merged. |
TobiGr
added
the
player
|
@karkaminski thanks for making that ugly text go away |
ghost
mentioned this pull request
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 21, 2021
…ent/remove_resizing_text removed resizing text from popup player
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence