Skip to content

Conversation

@triallax
Copy link
Contributor

@triallax triallax commented Feb 8, 2021

What is it?

  • Codebase improvement (dev facing)

Description of the changes in your PR

Remove License#contentUri.

I grepped the codebase and found nothing; I also built the project successfully, so I'm almost certain that it can be safely removed.

APK testing

app.zip

Due diligence

It seems to not be used anywhere.
@triallax triallax added the codequality Improvements to the codebase to improve the code quality label Feb 8, 2021
Copy link
Collaborator

@XiangRongLin XiangRongLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AS also shows no usage

@triallax
Copy link
Contributor Author

Sorry, I had meant to push that commit to test the APK autocomment PR.

@TobiGr TobiGr merged commit 8c75b96 into TeamNewPipe:dev Feb 14, 2021
@triallax triallax deleted the remove-content-uri branch February 15, 2021 05:46
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codequality Improvements to the codebase to improve the code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants