Prevent IllegalArgumentException when closing popup#5442
Merged
XiangRongLin merged 1 commit intoTeamNewPipe:devfrom Jan 18, 2021
Merged
Prevent IllegalArgumentException when closing popup#5442XiangRongLin merged 1 commit intoTeamNewPipe:devfrom
XiangRongLin merged 1 commit intoTeamNewPipe:devfrom
Conversation
7a7032f to
354c986
Compare
Member
|
more a symptomatic fix, but trivial enough to directly merge it. Is also hard to debug. |
354c986 to
d4a3360
Compare
XiangRongLin
approved these changes
Jan 18, 2021
Member
Author
|
@XiangRongLin feel free to merge ;-) |
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 21, 2021
Prevent IllegalArgumentException when closing popup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR fixes a random crash when closing the popup player. I could reproduce it consistently on
devby closing the popup player via theXin the notification, but it also happens on0.20.8at random times.Fixes
Crash log
Due diligence