Skip to content

Run Instrumented tests in CI pipeline#5360

Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom
XiangRongLin:instrumented_tests
Mar 31, 2021
Merged

Run Instrumented tests in CI pipeline#5360
TobiGr merged 1 commit intoTeamNewPipe:devfrom
XiangRongLin:instrumented_tests

Conversation

@XiangRongLin
Copy link
Collaborator

What is it?

  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Relies on the following changes

Notes

  • There currently are only 2 instrumentet tests, which means this doesn't really add much value yet. But i think having this already in place for when it is needed is good.
  • At first i wanted it to run it on API level 19 and 29 (min and max SDK) but it fails on 19 with it not being able to find the test (https://github.com/XiangRongLin/NewPipe/runs/1657271924?check_suite_focus=true#step:5:247). I assume its because of some problem with multidex and API < 21 since when i run it normally on API 19 emulator it logs a lot of errors with Could not find class 'xyz'.

Due diligence

@XiangRongLin XiangRongLin added the meta Related to the project but not strictly to code label Jan 14, 2021
@TobiGr TobiGr force-pushed the dev branch 2 times, most recently from 679bc75 to 2aeccc0 Compare March 16, 2021 08:24
@XiangRongLin XiangRongLin marked this pull request as ready for review March 20, 2021 13:27
@XiangRongLin XiangRongLin requested a review from Stypox March 20, 2021 17:08
@Stypox
Copy link
Member

Stypox commented Mar 20, 2021

Everything seems ok to me, though I don't have much experience with CI. What about also testing on API 21, alongside API 29?

@XiangRongLin XiangRongLin force-pushed the instrumented_tests branch 2 times, most recently from 4dbac2c to 12817ff Compare March 29, 2021 08:16
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's wait for @TobiGr's opinion ;-)

@XiangRongLin
Copy link
Collaborator Author

@Stypox The API level 29 was running for multiple hours for some reason. lets see if it is still like this on a rerun

@XiangRongLin
Copy link
Collaborator Author

Its working now. @TobiGr after merging the required check needs to be changed since i renamed it to build-and-test-jvm

@Stypox
Copy link
Member

Stypox commented Mar 31, 2021

@XiangRongLin I guess it is normal that build-and-test is skipped, since it was replaced by build-and-test-jvm, wasn't it? If that's the case then this is ready to merge I think.

@TobiGr TobiGr merged commit 8f0323f into TeamNewPipe:dev Mar 31, 2021
@TobiGr
Copy link
Contributor

TobiGr commented Mar 31, 2021

after merging the required check needs to be changed since i renamed it to build-and-test-jvm

Done. All workflows need to be run again now

tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 23, 2021
…ented_tests

Run Instrumented tests in CI pipeline
@XiangRongLin XiangRongLin deleted the instrumented_tests branch March 10, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Related to the project but not strictly to code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants