Remove APK testing section from PR template#5284
Merged
Stypox merged 1 commit intoTeamNewPipe:devfrom Jan 16, 2021
Merged
Conversation
This is because the our workflows build debug APKs now.
Member
|
We still need to complete the action. (Posting the comment with a direct link) |
Collaborator
|
I agree that it can't be completly removed yet. For now it can tell the contributor to copy the URL to the specific CI job where the apk can be downloaded. Also the information that the branch name is used as suffix in the app ID would need to be moved somewhere else. Otherwise that information gets lost. Contribution guidelines would be possible. |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Removed the APK testing section from the PR template because debug APKs are built by the automatically-run workflows now.
APK testing
-_-
Due diligence